Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 30 Mar 2021 09:43:55 +0200 | Subject | Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide |
| |
On Tue, Mar 30, 2021 at 9:30 AM Arnd Bergmann <arnd@kernel.org> wrote: > On Tue, Mar 30, 2021 at 9:22 AM Sergei Trofimovich <slyfox@gentoo.org> wrote: > > > @@ -451,7 +452,7 @@ struct CommandList { > > bool retry_pending; > > struct hpsa_scsi_dev_t *device; > > atomic_t refcount; /* Must be last to avoid memset in hpsa_cmd_init() */ > > -} __aligned(COMMANDLIST_ALIGNMENT); > > +} __packed __aligned(COMMANDLIST_ALIGNMENT); > > You are still marking CommandList as __packed here, which is > what caused the original problem. Please don't mark this one > as __packed at all. If there are individual members that you want > to be misaligned inside of the structure, you could mark those > explicitly.
Nevermind, I just got patch 2/3, splitting up the patches like this seems fine to me.
Whole series
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |