lkml.org 
[lkml]   [2021]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion
From
Date


On 2021/3/28 3:50, Guenter Roeck wrote:
> On 3/26/21 6:20 PM, Zhen Lei wrote:
>> The header file <linux/kernel.h> is already included above and can be
>> removed here.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Already submitted:
>
> https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/
>
> In general, when removing duplicate or unnecessary header files,
> please retain or improve alphabetic order. This patch makes it worse.

Okay, thanks for the heads-up. I'll pay attention next time.

>
> Guenter
>
>> ---
>> drivers/watchdog/dw_wdt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
>> index 32d0e1781e63c4e..b1642e2d9175584 100644
>> --- a/drivers/watchdog/dw_wdt.c
>> +++ b/drivers/watchdog/dw_wdt.c
>> @@ -19,7 +19,6 @@
>> #include <linux/delay.h>
>> #include <linux/err.h>
>> #include <linux/io.h>
>> -#include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/moduleparam.h>
>> #include <linux/interrupt.h>
>>
>
>
> .
>

\
 
 \ /
  Last update: 2021-03-31 03:55    [W:0.036 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site