Messages in this thread | | | Subject | Re: [PATCH RESEND] rsxx: Return -EFAULT if copy_to_user() fails | From | Jens Axboe <> | Date | Wed, 3 Mar 2021 06:49:33 -0700 |
| |
On 3/3/21 3:59 AM, Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes remaining but > we want to return -EFAULT to the user if it can't complete the copy. > The "st" variable only holds zero on success or negative error codes on > failure so the type should be int. > > Fixes: 36f988e978f8 ("rsxx: Adding in debugfs entries.") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > I sent this last June as part of a 2 patch series. No one responded > to the patches. The first patch was a NULL derefence fix but I now > think that the correct fix for that is to remove the "enable_blkdev" > module option... Anyway, this patch is uncontroversial so I'm going to > resend it.
Thanks Dan, applied.
-- Jens Axboe
| |