Messages in this thread | | | Date | Wed, 3 Mar 2021 10:15:35 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() |
| |
On Wed, Mar 03, 2021 at 06:04:22PM +0000, Russell King - ARM Linux admin wrote: > On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote: > > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() > > > > The following build error is emitted by rcutorture builds of v5.12-rc1: > > > > drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function] > > drivers/net/phy/phy_device.c:273:12: warning: ‘mdio_bus_phy_suspend’ defined but not used [-Wunused-function] > > > > The problem is that these functions are only used by SIMPLE_DEV_PM_OPS(), > > which creates a dev_pm_ops structure only in CONFIG_PM_SLEEP=y kernels. > > Therefore, the mdio_bus_phy_suspend() and mdio_bus_phy_suspend() functions > > will be used only in CONFIG_PM_SLEEP=y kernels. This commit therefore > > wraps them in #ifdef CONFIG_PM_SLEEP. > > Arnd submitted a patch that Jakub has applied which fix these warnings > in a slightly different way. Please see > 20210225145748.404410-1-arnd@kernel.org
Works for me! When will this be hitting mainline?
Not a huge deal given that I can suppress the resulting rcutorture failures by keeping a copy of either patch in -rcu, but I might not be the only one hitting this.
Thanx, Paul
| |