lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 106/254] bus: omap_l3_noc: mark l3 irqs as IRQF_NO_THREAD
    Date
    From: Grygorii Strashko <grygorii.strashko@ti.com>

    [ Upstream commit 7d7275b3e866cf8092bd12553ec53ba26864f7bb ]

    The main purpose of l3 IRQs is to catch OCP bus access errors and identify
    corresponding code places by showing call stack, so it's important to
    handle L3 interconnect errors as fast as possible. On RT these IRQs will
    became threaded and will be scheduled much more late from the moment actual
    error occurred so showing completely useless information.

    Hence, mark l3 IRQs as IRQF_NO_THREAD so they will not be forced threaded
    on RT or if force_irqthreads = true.

    Fixes: 0ee7261c9212 ("drivers: bus: Move the OMAP interconnect driver to drivers/bus/")
    Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bus/omap_l3_noc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
    index b040447575ad..dcfb32ee5cb6 100644
    --- a/drivers/bus/omap_l3_noc.c
    +++ b/drivers/bus/omap_l3_noc.c
    @@ -285,7 +285,7 @@ static int omap_l3_probe(struct platform_device *pdev)
    */
    l3->debug_irq = platform_get_irq(pdev, 0);
    ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
    - 0x0, "l3-dbg-irq", l3);
    + IRQF_NO_THREAD, "l3-dbg-irq", l3);
    if (ret) {
    dev_err(l3->dev, "request_irq failed for %d\n",
    l3->debug_irq);
    @@ -294,7 +294,7 @@ static int omap_l3_probe(struct platform_device *pdev)

    l3->app_irq = platform_get_irq(pdev, 1);
    ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
    - 0x0, "l3-app-irq", l3);
    + IRQF_NO_THREAD, "l3-app-irq", l3);
    if (ret)
    dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);

    --
    2.30.1


    \
     
     \ /
      Last update: 2021-03-29 10:55    [W:4.038 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site