lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH mvebu v3 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency
    Date
    Pali Rohár <pali@kernel.org> writes:

    > When current CPU load is not L0 then loading armada-37xx-cpufreq.ko driver
    > fails with following error:
    >
    > # modprobe armada-37xx-cpufreq
    > [ 502.702097] Unsupported CPU frequency 250 MHz
    >
    > This issue was partially fixed by commit 8db82563451f ("cpufreq:
    > armada-37xx: fix frequency calculation for opp"), but only for calculating
    > CPU frequency for opp.
    >
    > Fix this also for determination of base CPU frequency.
    >
    > Signed-off-by: Pali Rohár <pali@kernel.org>
    > Tested-by: Tomasz Maciej Nowak <tmn505@gmail.com>
    > Tested-by: Anders Trier Olesen <anders.trier.olesen@gmail.com>
    > Tested-by: Philip Soares <philips@netisense.com>
    > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx")
    > Cc: stable@vger.kernel.org # 8db82563451f ("cpufreq: armada-37xx: fix
    > frequency calculation for opp")

    Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>

    Thanks,

    Gregory

    > ---
    > drivers/cpufreq/armada-37xx-cpufreq.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
    > index 1ab2113daef5..e4782f562e7a 100644
    > --- a/drivers/cpufreq/armada-37xx-cpufreq.c
    > +++ b/drivers/cpufreq/armada-37xx-cpufreq.c
    > @@ -469,7 +469,7 @@ static int __init armada37xx_cpufreq_driver_init(void)
    > return -EINVAL;
    > }
    >
    > - dvfs = armada_37xx_cpu_freq_info_get(cur_frequency);
    > + dvfs = armada_37xx_cpu_freq_info_get(base_frequency);
    > if (!dvfs) {
    > clk_put(clk);
    > return -EINVAL;
    > --
    > 2.20.1
    >

    --
    Gregory Clement, Bootlin
    Embedded Linux and Kernel engineering
    http://bootlin.com

    \
     
     \ /
      Last update: 2021-03-29 17:01    [W:4.126 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site