lkml.org 
[lkml]   [2021]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues
On Sat, Mar 27, 2021 at 3:39 PM Joe Perches <joe@perches.com> wrote:
>
> On Sat, 2021-03-27 at 10:19 +0200, Andy Shevchenko wrote:
> > On Saturday, March 27, 2021, Xiaofei Tan <tanxiaofei@huawei.com> wrote:
> >
> > > Fix some coding style issues reported by checkpatch.pl, including
> > > following types:
> > >
> > > WARNING: simple_strtol is obsolete, use kstrtol instead
> >
> >
> > And one more thing, the above message is bogus. Read what the comments in
> > the code says about use cases for simple_*() vs. kstrto*() ones.
> >
> > Joe?
>
> This check and message is nearly 10 years old and was appropriate for
> when it was implemented.
>
> kernel.h currently has:
> * Use these functions if and only if you cannot use kstrto<foo>, because
>
> So the message could be changed to something like:
>
> WARNING: simple_strtol should be used only when kstrtol can not be used.

Fine with me, thanks!

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-03-27 17:41    [W:0.055 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site