Messages in this thread | | | Date | Sat, 27 Mar 2021 16:25:57 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS |
| |
> What I have works. Your consumers get quirk handling, mine don't need it. > No compromise.
Hi Don
All this discussion is now a mute point. GregKH has spoken.
But i'm sure there are some on the side lines, eating popcorn, maybe learning from the discussion.
Would you think it is O.K. to add a KAPI which works for 3 1/2" SCSI disks, but not 2", because you only make machines with 3 1/2" bays?
This is an extreme, absurd example, but hopefully you get the point. We don't design KAPIs with the intention to only work for a subset of devices. It needs to work with as many devices as possible, even if the first implementation below the KAPI is limited to just a subset.
Anyway, i'm gratefull you have looked at the new ethtool netlink KAPI. It will be better for your contributions. And i hope you can make use of it in the future. But i think this discussion about optoe in mainline is over.
Andrew
| |