Messages in this thread | | | Date | Sat, 27 Mar 2021 15:42:13 +0100 | From | Marek Behún <> | Subject | Re: [PATCH] PCI: Disallow retraining link for Atheros QCA98xx chips on non-Gen1 PCIe bridges |
| |
On Sat, 27 Mar 2021 14:29:59 +0100 Pali Rohár <pali@kernel.org> wrote:
> I can change this to 'if (!ret)' if needed, no problem. > > I use 'if (!val)' mostly for boolean and pointer variables. If > variable can contain more integer values then I lot of times I use > '=='.
Comparing integer varibales with explicit literals is sensible, but if a function returning integer returns 0 on success and negative value on error, Linux kernel has a tradition of using just if (!ret) or if (ret)
Marek
| |