Messages in this thread | | | Date | Fri, 26 Mar 2021 18:28:40 +0000 | From | Catalin Marinas <> | Subject | Re: [PATCH 1/4] arm64: expose orig_x0 in the user_pt_regs structure |
| |
On Mon, Mar 22, 2021 at 03:50:50PM -0700, Andrei Vagin wrote: > diff --git a/arch/arm64/include/uapi/asm/ptrace.h b/arch/arm64/include/uapi/asm/ptrace.h > index 758ae984ff97..3c118c5b0893 100644 > --- a/arch/arm64/include/uapi/asm/ptrace.h > +++ b/arch/arm64/include/uapi/asm/ptrace.h > @@ -90,6 +90,7 @@ struct user_pt_regs { > __u64 sp; > __u64 pc; > __u64 pstate; > + __u64 orig_x0; > };
That's a UAPI change, likely to go wrong. For example, a ptrace(PTRACE_GETREGSET, pid, REGSET_GPR, data) would write past the end of an old struct user_pt_regs in the debugger.
-- Catalin
| |