Messages in this thread | | | Subject | Re: [PATCH v2] MIPS: Add support for CONFIG_DEBUG_VIRTUAL | From | Florian Fainelli <> | Date | Fri, 26 Mar 2021 10:45:39 -0700 |
| |
On 3/25/2021 2:57 AM, Thomas Bogendoerfer wrote: > On Tue, Mar 23, 2021 at 03:20:43PM -0700, Florian Fainelli wrote: >> Provide hooks to intercept bad usages of virt_to_phys() and >> __pa_symbol() throughout the kernel. To make this possible, we need to >> rename the current implement of virt_to_phys() into >> __virt_to_phys_nodebug() and wrap it around depending on >> CONFIG_DEBUG_VIRTUAL. >> >> A similar thing is needed for __pa_symbol() which is now aliased to >> __phys_addr_symbol() whose implementation is either the direct return of >> RELOC_HIDE or goes through the debug version. >> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> Changes in v2: >> - fixed sparse warning in arch/mips/kernel/vdso.c > > checkpatch warns about a missing SPDX license in arch/mips/mm/physaddr.c, > can you please add one ?
Yes.
> > And as checkpatch is also unhappy about the volatiles, do we really > need them here ?
This is just following the existing prototypes for virt_to_phys() declared in arch/mips/include/asm/io.h. This can be changed to unsigned long if you prefer? -- Florian
| |