Messages in this thread Patch in this message | | | From | Pierre-Louis Bossart <> | Subject | [RFC PATCH 1/2] ASoC: lm49453: fix useless assignment before return | Date | Fri, 26 Mar 2021 17:16:18 -0500 |
| |
Cppcheck warning:
sound/soc/codecs/lm49453.c:1210:11: style: Variable 'pll_clk' is assigned a value that is never used. [unreadVariable]
pll_clk = BIT(4); ^
FIXME: What is the correct fix? /* fll clk slection */ pll_clk = BIT(4); return 0;
is the assignment redundant or the 'return 0' a mistake?
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/codecs/lm49453.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c index eb3dd0bd80d9..fb0fb23537e7 100644 --- a/sound/soc/codecs/lm49453.c +++ b/sound/soc/codecs/lm49453.c @@ -1206,8 +1206,6 @@ static int lm49453_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, break; case 48000: case 32576: - /* fll clk slection */ - pll_clk = BIT(4); return 0; default: return -EINVAL; -- 2.25.1
| |