Messages in this thread | | | Subject | Re: [PATCH 2/2] net: ipv4: route.c: Remove unnecessary if() | From | David Ahern <> | Date | Thu, 25 Mar 2021 08:36:59 -0600 |
| |
On 3/23/21 9:10 PM, Yejune Deng wrote: > negative_advice handler is only called when dst is non-NULL hence the > 'if (rt)' check can be removed. 'if' and 'else if' can be merged together. > And use container_of() instead of (struct rtable *). > > Signed-off-by: Yejune Deng <yejune.deng@gmail.com> > --- > net/ipv4/route.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) >
Reviewed-by: David Ahern <dsahern@kernel.org>
| |