| Subject | Re: [PATCH v2 8/8] block: add WARN() in bio_split() for sector alignment | From | Bart Van Assche <> | Date | Thu, 25 Mar 2021 20:47:43 -0700 |
| |
On 3/25/21 2:26 PM, Satya Tangirala wrote: > @@ -1458,6 +1458,7 @@ struct bio *bio_split(struct bio *bio, int sectors, > > BUG_ON(sectors <= 0); > BUG_ON(sectors >= bio_sectors(bio)); > + WARN_ON(!IS_ALIGNED(sectors, bio_required_sector_alignment(bio)));
Please change this WARN_ON() into WARN_ON_ONCE() to prevent a storm of call traces in the kernel log if this warning statement would be hit repeatedly.
Thanks,
Bart.
|