Messages in this thread | | | Date | Wed, 24 Mar 2021 11:17:16 +0100 | From | Greg KH <> | Subject | Re: [PATCH] misc: rtsx: check the value returned from a function for errors before being used |
| |
On Wed, Mar 24, 2021 at 06:05:58PM +0800, Yang Li wrote: > Add missing return value check in pm_runtime_get disabling the > sensor. The issue is reported by coverity with the following error: > > Medium:Unchecked return value(CHECKED_RETURN) > CWE252: Value returned from a function is not checked for errors before > being used. > Calling "pm_runtime_get" without checking return value. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/misc/cardreader/rtsx_pcr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/cardreader/rtsx_pcr.c b/drivers/misc/cardreader/rtsx_pcr.c > index 2733111..2cc37fd 100644 > --- a/drivers/misc/cardreader/rtsx_pcr.c > +++ b/drivers/misc/cardreader/rtsx_pcr.c > @@ -142,13 +142,16 @@ static void rtsx_pm_full_on(struct rtsx_pcr *pcr) > > void rtsx_pci_start_run(struct rtsx_pcr *pcr) > { > + int status; > /* If pci device removed, don't queue idle work any more */ > if (pcr->remove_pci) > return; > > if (pcr->rtd3_en) > if (pcr->is_runtime_suspended) { > - pm_runtime_get(&(pcr->pci->dev)); > + status = pm_runtime_get(&(pcr->pci->dev)); > + if (status < 0 && status != -EINPROGRESS) > + pm_runtime_put_noidle(&(pcr->pci->dev)); > pcr->is_runtime_suspended = false; > } > > -- > 1.8.3.1 >
Please always run scripts/checkpatch.pl on your patch before submitting it.
thanks,
greg k-h
| |