Messages in this thread | | | From | "Song Bao Hua (Barry Song)" <> | Subject | RE: [PATCH] dma-mapping: make map_benchmark compile into module | Date | Wed, 24 Mar 2021 07:33:23 +0000 |
| |
> -----Original Message----- > From: Christoph Hellwig [mailto:hch@lst.de] > Sent: Wednesday, March 24, 2021 8:13 PM > To: tiantao (H) <tiantao6@hisilicon.com> > Cc: akpm@linux-foundation.org; peterz@infradead.org; paulmck@kernel.org; > ast@kernel.org; tglx@linutronix.de; rostedt@goodmis.org; hch@lst.de; > m.szyprowski@samsung.com; Song Bao Hua (Barry Song) > <song.bao.hua@hisilicon.com>; iommu@lists.linux-foundation.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] dma-mapping: make map_benchmark compile into module > > On Wed, Mar 24, 2021 at 10:17:38AM +0800, Tian Tao wrote: > > under some scenarios, it is necessary to compile map_benchmark > > into module to test iommu, so this patch changed Kconfig and > > export_symbol to implement map_benchmark compiled into module. > > > > On the other hand, map_benchmark is a driver, which is supposed > > to be able to run as a module. > > > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > > Nope, we're not going to export more kthread internals for a test > module.
The requirement comes from an colleague who is frequently changing the map-bench code for some customized test purpose. and he doesn't want to build kernel image and reboot every time. So I moved the requirement to Tao Tian.
Right now, kthread_bind() is exported, kthread_bind_mask() seems to be a little bit "internal" as you said, maybe a wrapper like kthread_bind_node() won't be that "internal", comparing to exposing the cpumask? Anyway, we don't find other driver users for this, hardly I can convince you it is worth.
Thanks Barry
| |