lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH resend 3/4] nfc: fix memory leak in llcp_sock_connect()
    Date
    In llcp_sock_connect(), use kmemdup to allocate memory for
    "llcp_sock->service_name". The memory is not released in the sock_unlink
    label of the subsequent failure branch.
    As a result, memory leakage occurs.

    fix CVE-2020-25672

    Fixes: d646960f7986 ("NFC: Initial LLCP support")
    Reported-by: "kiyin(尹亮)" <kiyin@tencent.com>
    Link: https://www.openwall.com/lists/oss-security/2020/11/01/1
    Cc: <stable@vger.kernel.org> #v3.3
    Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
    ---
    net/nfc/llcp_sock.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c
    index 9e2799ee1595..59172614b249 100644
    --- a/net/nfc/llcp_sock.c
    +++ b/net/nfc/llcp_sock.c
    @@ -746,6 +746,8 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr,

    sock_unlink:
    nfc_llcp_sock_unlink(&local->connecting_sockets, sk);
    + kfree(llcp_sock->service_name);
    + llcp_sock->service_name = NULL;

    sock_llcp_release:
    nfc_llcp_put_ssap(local, llcp_sock->ssap);
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-03-25 04:52    [W:4.307 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site