Messages in this thread | | | Date | Thu, 25 Mar 2021 11:50:43 +0800 | From | Jisheng Zhang <> | Subject | Re: [PATCH] tee: optee: add invoke_fn tracepoints |
| |
On Wed, 24 Mar 2021 10:53:13 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Wed, 24 Mar 2021 07:48:53 -0700 > Guenter Roeck <linux@roeck-us.net> wrote: > > > On Wed, Mar 24, 2021 at 07:34:07AM -0700, Guenter Roeck wrote: > > > On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote: > > > > Add tracepoints to retrieve information about the invoke_fn. This would > > > > help to measure how many invoke_fn are triggered and how long it takes > > > > to complete one invoke_fn call. > > > > > > > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > > > > > > arm64:defconfig: > > > > > > make-arm64 -j drivers/tee/optee/call.o > > > CALL scripts/atomic/check-atomics.sh > > > CALL scripts/checksyscalls.sh > > > CC drivers/tee/optee/call.o > > > In file included from drivers/tee/optee/optee_trace.h:67, > > > from drivers/tee/optee/call.c:18: > > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory > > > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > > > | ^ > > > compilation terminated.
Interesting, I always build linux kernel with "O=", didn't see such build error and IIRC, we didn't receive any lkp robot build error report.
My steps are:
mkdir /tmp/test
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=/tmp/test defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=/tmp/test drivers/tee/optee/
Today, I tried to build the linux kernel w/o "O=...", I reproduced this error! This is the first time I saw "O=" make a different behavior.
I'll send out a patch to fix it.
Thanks
> > > > > > > The problem also affects arm:imx_v6_v7_defconfig. > > > > I think it affects everything. The problem is that the > drivers/tee/optee/Makefile needs to be updated with: > > CFLAGS_call.o := -I$(src) > > otherwise the compiler wont know how to find the path to optee_tree.h. > > This is described in: > > samples/trace_events/Makefile
Thank Steven for pointing this out.
| |