lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/2] usbip: tools: add usage of device mode in usbip_list.c
From
Date
On 3/24/21 1:56 AM, Hongren Zheng (Zenithal) wrote:
> The option '-d/--device' was implemented in 'usbip list' but not
> shown in usage. Hence this commit adds this option to usage.
>
> Signed-off-by: Hongren Zheng <i@zenithal.me>
> ---
> tools/usb/usbip/src/usbip_list.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> PATCH v2:
> Add signed-off-by line
>
> PATCH v3:
> Move patch changelog after the marker line
> Remove nickname in signed-off-by line
>
> PATCH v4:
> Use commit short hash and message instead of long hash only when
> referring to commit in the kernel
>
> PATCH v5:
> Add documentation of `usbip port` and its usage in examples
> Add flow of detaching in examples
> Rephrase some description and add punctuations
> Fix typo of `usbip attach --ev-id` to `--dev-id`
>
> diff --git a/tools/usb/usbip/src/usbip_list.c b/tools/usb/usbip/src/usbip_list.c
> index 8625b0f514ee..3d810bcca02f 100644
> --- a/tools/usb/usbip/src/usbip_list.c
> +++ b/tools/usb/usbip/src/usbip_list.c
> @@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
> "usbip list [-p|--parsable] <args>\n"
> " -p, --parsable Parsable list format\n"
> " -r, --remote=<host> List the exportable USB devices on <host>\n"
> - " -l, --local List the local USB devices\n";
> + " -l, --local List the local USB devices\n"
> + " -d, --device List the local USB gadgets bound to usbip-vudc\n";
>
> void usbip_list_usage(void)
> {
>

Thank you. Looks good.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

\
 
 \ /
  Last update: 2021-03-25 00:52    [W:0.142 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site