Messages in this thread | | | Date | Wed, 24 Mar 2021 20:43:43 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH V2 3/5] tools/perf: Add powerpc support for PERF_SAMPLE_WEIGHT_STRUCT |
| |
On Mon, Mar 22, 2021 at 10:57:25AM -0400, Athira Rajeev wrote: > Add arch specific arch_evsel__set_sample_weight() to set the new > sample type for powerpc. > > Add arch specific arch_perf_parse_sample_weight() to store the > sample->weight values depending on the sample type applied. > if the new sample type (PERF_SAMPLE_WEIGHT_STRUCT) is applied, > store only the lower 32 bits to sample->weight. If sample type > is 'PERF_SAMPLE_WEIGHT', store the full 64-bit to sample->weight. > > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > --- > tools/perf/arch/powerpc/util/Build | 2 ++ > tools/perf/arch/powerpc/util/event.c | 32 ++++++++++++++++++++++++++++++++ > tools/perf/arch/powerpc/util/evsel.c | 8 ++++++++ > 3 files changed, 42 insertions(+) > create mode 100644 tools/perf/arch/powerpc/util/event.c > create mode 100644 tools/perf/arch/powerpc/util/evsel.c > > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build > index b7945e5a543b..8a79c4126e5b 100644 > --- a/tools/perf/arch/powerpc/util/Build > +++ b/tools/perf/arch/powerpc/util/Build > @@ -4,6 +4,8 @@ perf-y += kvm-stat.o > perf-y += perf_regs.o > perf-y += mem-events.o > perf-y += sym-handling.o > +perf-y += evsel.o > +perf-y += event.o > > perf-$(CONFIG_DWARF) += dwarf-regs.o > perf-$(CONFIG_DWARF) += skip-callchain-idx.o > diff --git a/tools/perf/arch/powerpc/util/event.c b/tools/perf/arch/powerpc/util/event.c > new file mode 100644 > index 000000000000..f49d32c2c8ae > --- /dev/null > +++ b/tools/perf/arch/powerpc/util/event.c > @@ -0,0 +1,32 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include <linux/types.h> > +#include <linux/string.h> > +#include <linux/zalloc.h> > + > +#include "../../../util/event.h" > +#include "../../../util/synthetic-events.h" > +#include "../../../util/machine.h" > +#include "../../../util/tool.h" > +#include "../../../util/map.h" > +#include "../../../util/debug.h"
nit, just #include "utils/...h" should work no?
other than that, the patchset looks ok to me
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, jirka
> + > +void arch_perf_parse_sample_weight(struct perf_sample *data, > + const __u64 *array, u64 type) > +{ > + union perf_sample_weight weight; > + > + weight.full = *array; > + if (type & PERF_SAMPLE_WEIGHT) > + data->weight = weight.full; > + else > + data->weight = weight.var1_dw; > +} > + > +void arch_perf_synthesize_sample_weight(const struct perf_sample *data, > + __u64 *array, u64 type) > +{ > + *array = data->weight; > + > + if (type & PERF_SAMPLE_WEIGHT_STRUCT) > + *array &= 0xffffffff; > +} > diff --git a/tools/perf/arch/powerpc/util/evsel.c b/tools/perf/arch/powerpc/util/evsel.c > new file mode 100644 > index 000000000000..2f733cdc8dbb > --- /dev/null > +++ b/tools/perf/arch/powerpc/util/evsel.c > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include <stdio.h> > +#include "util/evsel.h" > + > +void arch_evsel__set_sample_weight(struct evsel *evsel) > +{ > + evsel__set_sample_bit(evsel, WEIGHT_STRUCT); > +} > -- > 1.8.3.1 >
| |