lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
    Date
    There has spin lock for irq set type already, so drop irq_gc_lock and
    irq_gc_unlock.

    Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
    ---
    drivers/gpio/gpio-rockchip.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
    index 048e7eecddba..c9c55614bbef 100644
    --- a/drivers/gpio/gpio-rockchip.c
    +++ b/drivers/gpio/gpio-rockchip.c
    @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
    irq_set_handler_locked(d, handle_level_irq);

    raw_spin_lock_irqsave(&bank->slock, flags);
    - irq_gc_lock(gc);

    level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type);
    polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity);
    @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
    rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type);
    rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity);
    out:
    - irq_gc_unlock(gc);
    raw_spin_unlock_irqrestore(&bank->slock, flags);

    return ret;
    --
    2.25.1


    \
     
     \ /
      Last update: 2021-03-24 07:48    [W:3.909 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site