Messages in this thread | | | Subject | Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys | From | Ahmad Fatoum <> | Date | Tue, 23 Mar 2021 17:35:41 +0100 |
| |
Hello Horia,
On 21.03.21 21:48, Horia Geantă wrote: > On 3/16/2021 7:02 PM, Ahmad Fatoum wrote: > [...] >> +struct trusted_key_ops caam_trusted_key_ops = { >> + .migratable = 0, /* non-migratable */ >> + .init = trusted_caam_init, >> + .seal = trusted_caam_seal, >> + .unseal = trusted_caam_unseal, >> + .exit = trusted_caam_exit, >> +}; > caam has random number generation capabilities, so it's worth using that > by implementing .get_random.
If the CAAM HWRNG is already seeding the kernel RNG, why not use the kernel's?
Makes for less code duplication IMO.
> > Horia >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |