lkml.org 
[lkml]   [2021]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][next] media: dvb-frontends: Remove redundant error check on variable ret
    Date
    From: Colin Ian King <colin.king@canonical.com>

    An earlier commit removed a call to lgdt3306a_spectral_inversion and
    omitted to remove the error return check. The check on ret is now
    redundant and can be removed.

    Addresses-Coverity: ("Logically dead code")
    Fixes: d4a3fa6652e3 ("media: dvb-frontends: lgdt3306a.c: remove dead code")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/media/dvb-frontends/lgdt3306a.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
    index 22d484487695..136b76cb4807 100644
    --- a/drivers/media/dvb-frontends/lgdt3306a.c
    +++ b/drivers/media/dvb-frontends/lgdt3306a.c
    @@ -1017,9 +1017,6 @@ static int lgdt3306a_set_parameters(struct dvb_frontend *fe)

    /* spectral_inversion defaults already set for VSB and QAM */

    - if (lg_chkerr(ret))
    - goto fail;
    -
    ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode);
    if (lg_chkerr(ret))
    goto fail;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-03-23 15:02    [W:3.865 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site