lkml.org 
[lkml]   [2021]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 06/17] auxdisplay: Extract character line display core support
    Hi Robin,

    On Tue, Mar 23, 2021 at 9:18 AM robin <robin@protonic.nl> wrote:
    > On 2021-03-22 15:48, Geert Uytterhoeven wrote:
    > > Extract the character line display core support from the simple ASCII
    > > LCD driver for the MIPS Boston, Malta & SEAD3 development boards into
    > > its own subdriver, so it can be reused for other displays.
    > >
    > > Note that this moves the "message" device attribute in sysfs in a
    > > "linedisp.N" subdirectory.
    > >
    > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

    > > --- a/drivers/auxdisplay/Kconfig
    > > +++ b/drivers/auxdisplay/Kconfig
    > > @@ -25,6 +25,12 @@ config CHARLCD
    > > This is some character LCD core interface that multiple drivers can
    > > use.
    > >
    > > +config LINEDISP
    > > + tristate "Character line display core support" if COMPILE_TEST
    > > + help
    > > + This is the core support for single-line character displays, to be
    > > + selected by drivers that use it.
    > > +
    > > config HD44780_COMMON
    > > tristate "Common functions for HD44780 (and compatibles) LCD
    > > displays" if COMPILE_TEST
    > > select CHARLCD
    > > @@ -155,6 +161,7 @@ config IMG_ASCII_LCD
    > > depends on HAS_IOMEM
    > > default y if MIPS_MALTA
    > > select MFD_SYSCON
    > > + select LINEDISP
    > > help
    > > Enable this to support the simple ASCII LCD displays found on
    > > development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
    > > @@ -169,6 +176,7 @@ config HT16K33
    > > select FB_SYS_IMAGEBLIT
    > > select INPUT_MATRIXKMAP
    > > select FB_BACKLIGHT
    > > + select LINEDISP
    >
    > At this point in your patch stack it's not used by the ht16k33 driver. I
    > think it
    > would be nicer to add this dependency when the code actually starts
    > depending on it.
    > So that when this patch stack gets applied partially or not in one go
    > the chunks
    > would be independent.

    Indeed, I messed up the order. Will fix.
    Thanks for spotting!

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2021-03-23 09:54    [W:2.754 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site