lkml.org 
[lkml]   [2021]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 117/157] usbip: Fix incorrect double assignment to udc->ud.tcp_rx
    Date
    From: Colin Ian King <colin.king@canonical.com>

    commit 9858af27e69247c5d04c3b093190a93ca365f33d upstream.

    Currently udc->ud.tcp_rx is being assigned twice, the second assignment
    is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.

    Fixes: 46613c9dfa96 ("usbip: fix vudc usbip_sockfd_store races leading to gpf")
    Acked-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Cc: stable <stable@vger.kernel.org>
    Addresses-Coverity: ("Unused value")
    Link: https://lore.kernel.org/r/20210311104445.7811-1-colin.king@canonical.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/usbip/vudc_sysfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/usbip/vudc_sysfs.c
    +++ b/drivers/usb/usbip/vudc_sysfs.c
    @@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct

    udc->ud.tcp_socket = socket;
    udc->ud.tcp_rx = tcp_rx;
    - udc->ud.tcp_rx = tcp_tx;
    + udc->ud.tcp_tx = tcp_tx;
    udc->ud.status = SDEV_ST_USED;

    spin_unlock_irq(&udc->ud.lock);

    \
     
     \ /
      Last update: 2021-03-22 13:50    [W:2.670 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site