Messages in this thread | | | Date | Mon, 22 Mar 2021 22:52:44 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net] net: dsa: don't assign an error value to tag_ops |
| |
On Mon, Mar 22, 2021 at 03:26:50PM -0500, George McCollister wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in deferencing an invalid > pointer when a deferred switch configuration happens later. > > Fixes: 357f203bb3b5 ("net: dsa: keep a copy of the tagging protocol in the DSA switch tree") > > Signed-off-by: George McCollister <george.mccollister@gmail.com> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Just FYI, new lines aren't typically added between the various tags.
| |