lkml.org 
[lkml]   [2021]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems
    On 18:42-20210322, Aswath Govindraju wrote:
    > The following speed modes are now supported in J7200 SoC,
    > - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1].
    > - UHS-I speed modes in MMCSD1 subsystem [1].
    >
    > Add support for UHS-I modes by adding voltage regulator device tree nodes
    > and corresponding pinmux details, to power cycle and voltage switch cards.
    > Set respective tags in sdhci0 and remove no-1-8-v tag from sdhci1
    > device tree nodes.
    >
    > Also update the delay values for various speed modes supported, based on
    > the revised january 2021 J7200 datasheet[2].
    >
    > [1] - section 12.3.6.1.1 MMCSD Features, in
    > https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf,
    > (SPRUIU1A – JULY 2020 – REVISED JANUARY 2021)
    >
    > [2] - https://www.ti.com/lit/ds/symlink/dra821u.pdf,
    > (SPRSP57B – APRIL 2020 – REVISED JANUARY 2021)
    >
    > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
    > ---
    > .../dts/ti/k3-j7200-common-proc-board.dts | 42 +++++++++++++++++++
    > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 14 ++++++-
    > 2 files changed, 54 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
    > index b493f939b09a..de8c06bdc825 100644
    > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
    > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
    > @@ -16,6 +16,29 @@
    > stdout-path = "serial2:115200n8";
    > bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
    > };
    > +
    > + vdd_mmc1: fixedregulator-sd {
    > + compatible = "regulator-fixed";
    > + regulator-name = "vdd_mmc1";
    > + regulator-min-microvolt = <3300000>;
    > + regulator-max-microvolt = <3300000>;
    > + regulator-boot-on;
    > + enable-active-high;
    > + gpios = <&exp2 2 GPIO_ACTIVE_HIGH>;

    is that gpio ?
    I'd encourage to use vin-supply as well.

    > + };
    > +
    > + vdd_sd_dv: gpio-regulator-vdd-sd-dv {
    What does this drive? TLV71033 ?
    > + compatible = "regulator-gpio";
    > + regulator-name = "vdd_sd_dv";
    > + pinctrl-names = "default";
    > + pinctrl-0 = <&vdd_sd_dv_pins_default>;
    > + regulator-min-microvolt = <1800000>;
    > + regulator-max-microvolt = <3300000>;
    > + regulator-boot-on;

    normally, I'd encourage to use vin-supply as well.

    > + gpios = <&main_gpio0 55 GPIO_ACTIVE_HIGH>;
    > + states = <1800000 0x0
    > + 3300000 0x1>;
    states = <1800000 0x0>,
    <3300000 0x1>;

    Can you look at j721e as reference?

    > + };
    > };
    >

    Kishon,
    can you look closer at this series?
    --
    Regards,
    Nishanth Menon
    Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

    \
     
     \ /
      Last update: 2021-03-22 16:37    [W:2.190 / U:1.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site