lkml.org 
[lkml]   [2021]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c
On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billauer@gmail.com wrote:
> From: Eli Billauer <eli.billauer@gmail.com>
>
> This patch is a preparation for adding another related driver, XillyUSB.
> In order to share some code between the existing Xillybus driver and the
> one to be added, some functions are moved to xillybus_class.c
>
> The header file, xillybus_class.h, is temporarily placed in include/linux/,
> because the new XillyUSB driver is intended as a staging driver for the
> time being.
>
> Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
> ---
>
> Notes:
> Changelog:
>
> v4:
> - Fix error code return value bugs in xillybus_init_chrdev() as detected by
> Smatch test robot, and reported by Dan Carpenter.
>
> This patch did not exist prior to v3.
>
> drivers/char/xillybus/Kconfig | 4 +
> drivers/char/xillybus/Makefile | 1 +
> drivers/char/xillybus/xillybus.h | 10 +-
> drivers/char/xillybus/xillybus_class.c | 263 +++++++++++++++++++++++++
> drivers/char/xillybus/xillybus_core.c | 181 +++--------------
> include/linux/xillybus_class.h | 30 +++
> 6 files changed, 322 insertions(+), 167 deletions(-)
> create mode 100644 drivers/char/xillybus/xillybus_class.c
> create mode 100644 include/linux/xillybus_class.h
>
> diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig
> index 130dbdce858f..e7800f025249 100644
> --- a/drivers/char/xillybus/Kconfig
> +++ b/drivers/char/xillybus/Kconfig
> @@ -3,10 +3,14 @@
> # Xillybus devices
> #
>
> +config XILLYBUS_CLASS
> + tristate
> +
> config XILLYBUS
> tristate "Xillybus generic FPGA interface"
> depends on PCI || OF
> select CRC32
> + select XILLYBUS_CLASS

depends on, do not select.

\
 
 \ /
  Last update: 2021-03-21 13:25    [W:0.063 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site