lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ASoC: codec: Omit superfluous error message in jz4760_codec_probe()


Le mar. 2 mars 2021 à 21:56, Tang Bin <tangbin@cmss.chinamobile.com> a
écrit :
> The function devm_platform_ioremap_resource has already contained
> error message, so remove the redundant dev_err here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!

Cheers,
-Paul

> ---
> Changes from v1
> - to streamline the code.
> ---
> sound/soc/codecs/jz4760.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c
> index e8f28ccc145a..5ae0e312bcfc 100644
> --- a/sound/soc/codecs/jz4760.c
> +++ b/sound/soc/codecs/jz4760.c
> @@ -841,11 +841,8 @@ static int jz4760_codec_probe(struct
> platform_device *pdev)
> codec->dev = dev;
>
> codec->base = devm_platform_ioremap_resource(pdev, 0);
> - if (IS_ERR(codec->base)) {
> - ret = PTR_ERR(codec->base);
> - dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(codec->base))
> + return PTR_ERR(codec->base);
>
> codec->regmap = devm_regmap_init(dev, NULL, codec,
> &jz4760_codec_regmap_config);
> --
> 2.18.2
>
>
>


\
 
 \ /
  Last update: 2021-03-02 18:09    [W:0.048 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site