Messages in this thread | | | Date | Tue, 2 Mar 2021 09:59:00 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/2] perf daemon: Fix control fifo permissions |
| |
Em Mon, Mar 01, 2021 at 01:25:09PM +0100, Jiri Olsa escreveu: > Add proper mode for mkfifo calls to get read and > write permissions for user. We can't use O_RDWR > in here, changing to standard permission value.
Thanks, applied both patches to perf/urgent.
- Arnaldo
> Fixes: 6a6d1804a190 ("perf daemon: Set control fifo for session") > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/perf/builtin-daemon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c > index 617feaf020f6..8f0ed2e59280 100644 > --- a/tools/perf/builtin-daemon.c > +++ b/tools/perf/builtin-daemon.c > @@ -373,12 +373,12 @@ static int daemon_session__run(struct daemon_session *session, > dup2(fd, 2); > close(fd); > > - if (mkfifo(SESSION_CONTROL, O_RDWR) && errno != EEXIST) { > + if (mkfifo(SESSION_CONTROL, 0600) && errno != EEXIST) { > perror("failed: create control fifo"); > return -1; > } > > - if (mkfifo(SESSION_ACK, O_RDWR) && errno != EEXIST) { > + if (mkfifo(SESSION_ACK, 0600) && errno != EEXIST) { > perror("failed: create ack fifo"); > return -1; > } > -- > 2.29.2 >
--
- Arnaldo
| |