lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 1/8] mm: Remove special swap entry functions
Date
On Tuesday, 2 March 2021 7:52:53 PM AEDT Alistair Popple wrote:
> On Saturday, 27 February 2021 2:59:09 AM AEDT Christoph Hellwig wrote:
> > > - struct page *page = migration_entry_to_page(entry);
> > > + struct page *page = pfn_to_page(swp_offset(entry));
> >
> > I wonder if keeping a single special_entry_to_page() helper would still
> > me a useful. But I'm not entirely sure. There are also two more open
> > coded copies of this in the THP migration code.
>
> I think it might be if only to clearly document where these entries are
used.
> Will add it for the next version to see what it looks like.

Actually the main advantage ends up being that it becomes easy to retain the
page locked check for migration entries.

- Alistair



\
 
 \ /
  Last update: 2021-03-02 17:09    [W:0.054 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site