Messages in this thread | | | From | "Coelho, Luciano" <> | Subject | Re: [PATCH] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle()) | Date | Tue, 2 Mar 2021 10:48:08 +0000 |
| |
On Tue, 2021-03-02 at 10:27 +0100, Jiri Kosina wrote: > On Mon, 1 Mar 2021, Johannes Berg wrote: > > > > I am getting the splat below with Linus' tree as of today (5.11-rc1, > > > fe07bfda2fb). I haven't started to look into the code yet, but apparently > > > this has been already reported by Heiner here: > > > > > > https://www.spinics.net/lists/linux-wireless/msg208353.html > > > > > > so before I start digging deep into it (the previous kernel this > > > particular machine had is 5.9, so I'd rather avoid lenghty bisect for now > > > in case someone has already looked into it and has ideas where the problem > > > is), I thought I'd ask whether this has been root-caused elsewhere > > > already. > > > > Yeah, I'm pretty sure we have a fix for this, though I'm not sure right > > now where it is in the pipeline. > > > > It's called "iwlwifi: pcie: don't add NAPI under rxq->lock" but right > > now I can't find it in any of the public archives. > > I was not able to find that patch anywhere indeed, but in the meantime I > fixed it by the patch below. Please consider merging either of the fixes.
I checked my queue and I realized that the patch Johannes mentioned was marked as a fix for a fix and my script had issues with recursive fixes. It normally squashes fixes to patches before the latter are sent out. My bad.
Kalle, please take Jiri's v2 to wireless-drivers.git. I'll give my ack separately in reply to v2.
-- Cheers, Luca.
| |