Messages in this thread | | | Date | Tue, 2 Mar 2021 09:31:09 +0000 | From | Lee Jones <> | Subject | Re: [PATCH rdma-rc 1/2] RDMA/mlx5: Set correct kernel-doc identifier |
| |
On Tue, 02 Mar 2021, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com> > > The W=1 allmodconfig build produces the following warning: > drivers/infiniband/hw/mlx5/odp.c:1086: warning: wrong kernel-doc identifier on line: > * Parse a series of data segments for page fault handling. > > Fix it by changing /** to be /* as it is written in kernel-doc documentation. > > Fixes: 5e769e444d26 ("RDMA/hw/mlx5/odp: Fix formatting and add missing descriptions in 'pagefault_data_segments()'") > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/hw/mlx5/odp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c > index 374698186662..b103555b1f5d 100644 > --- a/drivers/infiniband/hw/mlx5/odp.c > +++ b/drivers/infiniband/hw/mlx5/odp.c > @@ -1082,7 +1082,7 @@ static int pagefault_single_data_segment(struct mlx5_ib_dev *dev, > return ret ? ret : npages; > } > > -/** > +/*
This is not the correct fix.
Kernel-doc is asking for the function name.
> * Parse a series of data segments for page fault handling. > * > * @dev: Pointer to mlx5 IB device
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |