Messages in this thread | | | Date | Tue, 2 Mar 2021 10:14:14 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH 3/3] ARM: dts: sun8i: V3/S3: add i2s peripheral |
| |
Hi,
On Fri, Feb 26, 2021 at 11:30:28AM +0100, Tobias Schramm wrote: > The V3 and S3 SoCs feature an i2s peripheral identical to that of the H3. > Add it to the dts. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
Why is it added to the v3 DTSI and not the global one?
> --- > arch/arm/boot/dts/sun8i-v3.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi b/arch/arm/boot/dts/sun8i-v3.dtsi > index c279e13583ba..17ea6b8f091f 100644 > --- a/arch/arm/boot/dts/sun8i-v3.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3.dtsi > @@ -30,3 +30,18 @@ uart1_pg_pins: uart1-pg-pins { > function = "uart1"; > }; > }; > + > +&soc {
You don't need a label for that, you can just put it under / { soc {
> + i2s0: i2s@1c22000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun8i-h3-i2s";
We should also have a v3 specific compatible here in addition to the H3 (and document it in the bindings).
Maxime [unhandled content-type:application/pgp-signature] | |