Messages in this thread | | | Subject | Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[] | From | Colin Ian King <> | Date | Tue, 2 Mar 2021 08:54:09 +0000 |
| |
On 02/03/2021 08:44, Krzysztof Kozlowski wrote: > On Tue, Feb 23, 2021 at 07:38:21PM +0000, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Currently the array gpmc_cs is indexed by cs before it cs is range checked >> and the pointer read from this out-of-index read is dereferenced. Fix this >> by performing the range check on cs before the read and the following >> pointer dereference. >> >> Addresses-Coverity: ("Negative array index read") >> Fixes: 186401937927 ("memory: gpmc: Move omap gpmc code to live under drivers") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/memory/omap-gpmc.c | 7 +++++-- > > Thanks, applied with Tony's ack and changed Fixes to 9ed7a776eb50 ("ARM: > OMAP2+: Fix support for multiple devices on a GPMC chip select").
Thanks for correcting the Fixes line
> > Best regards, > Krzysztof >
| |