| From | Max Filippov <> | Date | Mon, 1 Mar 2021 22:57:10 -0800 | Subject | Re: [PATCH 34/44] tty: do not check tty_unregister_driver's return value |
| |
On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby <jslaby@suse.cz> wrote: > > These drivers check tty_unregister_driver return value. But they don't > handle a failure correctly (they free the driver in any case). So stop > checking tty_unregister_driver return value and remove also the prints. > > In the next patch, tty_unregister_driver's return type will be switched > to void. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Chris Zankel <chris@zankel.net> > Cc: Max Filippov <jcmvbkbc@gmail.com> > Cc: linux-xtensa@linux-xtensa.org > Cc: Jiri Kosina <jikos@kernel.org> > Cc: David Sterba <dsterba@suse.com> > --- > arch/xtensa/platforms/iss/console.c | 6 +----- > drivers/tty/amiserial.c | 8 ++------ > drivers/tty/ipwireless/tty.c | 7 +------ > drivers/tty/moxa.c | 4 +--- > drivers/tty/serial/kgdb_nmi.c | 4 +--- > drivers/tty/synclink_gt.c | 5 +---- > 6 files changed, 7 insertions(+), 27 deletions(-)
Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
-- Thanks. -- Max
|