Messages in this thread | | | From | Gene Chen <> | Date | Tue, 2 Mar 2021 14:08:18 +0800 | Subject | Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions |
| |
Pavel Machek <pavel@ucw.cz> 於 2021年2月19日 週五 下午6:47寫道: > > Hi! > > > From: Gene Chen <gene_chen@richtek.com> > > > > Add LED_FUNCTION_MOONLIGHT definitions > > > > Signed-off-by: Gene Chen <gene_chen@richtek.com> > > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Acked-by: Rob Herring <robh@kernel.org> > > No, sorry, I don't believe we need another define for flash/torch. >
As previous discuss, > We use term "Moonlight" as reference says > "When you are trying to imitate moonlight you need to use low voltage, > softer lighting. You don’t want something that’s too bright" > which is focus on brightness instead of color.
If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead? (refs: https://lkml.org/lkml/2020/11/24/1267)
> Best regards, > Pavel > -- > http://www.livejournal.com/~pavelmachek
| |