lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling
Hi Geert,

On Tue, Mar 02, 2021 at 05:18:21PM +0100, Geert Uytterhoeven wrote:
> Hi Sebastian,
>
> On Tue, Mar 2, 2021 at 4:44 PM Sebastian Reichel <sre@kernel.org> wrote:
> > On Fri, Feb 05, 2021 at 02:33:19PM +0100, Geert Uytterhoeven wrote:
> > > Currently, there are two drivers binding to the R-Mobile System
> > > Controller (SYSC):
> > > - The rmobile-sysc driver registers PM domains from a core_initcall(),
> > > and does not use a platform driver,
> > > - The rmobile-reset driver registers a reset handler, and does use a
> > > platform driver.
> > >
> > > As fw_devlink only considers devices, it does not know that the
> > > rmobile-sysc driver is ready. Hence if fw_devlink is enabled, probing
> > > of on-chip devices that are part of the SYSC PM domain is deferred until
> > > the optional rmobile-reset has been bound, which may happen too late
> > > (for e.g. the system timer on SoCs lacking an ARM architectured or
> > > global timer), or not at all, leading to complete system boot failures.
> > >
> > > Fix this by:
> > > 1. Setting the OF_POPULATED flag for the SYSC device node after
> > > successful initialization.
> > > This will make of_link_to_phandle() ignore the SYSC device node as
> > > a dependency, making consumer devices probe again.
> > > 2. Move reset handling from its own driver into the rmobile-sysc
> > > driver.
> > > This is needed because setting OF_POPULATED prevents the
> > > rmobile-reset driver from binding against the same device.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > To be queued in renesas-devel for v5.13.
> >
> > Acked-by: Sebastian Reichel <sre@kernel.org>
>
> In the meantime, this has method been abandoned, and this patch was
> superseded by "[PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when
> PM domain is added"
> https://lore.kernel.org/linux-arm-kernel/20210216123958.3180014-1-geert+renesas@glider.be/

Ah I remember seeing that, wondering why I am being CC'd and
ignoring it :)

Thanks for the pointer,

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-03-03 03:41    [W:0.053 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site