lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8192e: remove unnecessary break
On Tue, Mar 02, 2021 at 11:29:03PM +0800, Perrin Smith wrote:
> From: Perrin Smith <perrinjamessmith@gmail.com>
>
> removed unnecessary break at end of while loop
>
> Signed-off-by: Perrin Smith <perrinjamessmith@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index b8ab34250e6a..2de6330b7737 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -460,8 +460,6 @@ static bool AddReorderEntry(struct rx_ts_record *pTS,
> ((struct rx_reorder_entry *)list_entry(pList->next,
> struct rx_reorder_entry, List))->SeqNum))
> return false;
> - else
> - break;

No, this break is necessary. The patch introduces a bug. You need to
be careful following checkpatch's advice because it's just a simple
Perl script.

> }

regards,
dan carpenter

\
 
 \ /
  Last update: 2021-03-03 03:41    [W:0.048 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site