lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: soc-core: Prevent warning if no DMI table is present
On Tue, 02 Mar 2021 13:49:13 +0100,
Mark Brown wrote:
>
> On Tue, Mar 02, 2021 at 09:27:12AM +0000, Jon Hunter wrote:
> > Many systems do not provide a DMI table and on these systems a warning,
> > such as the following, is printed on boot ...
> >
> > WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name!
> >
> > If DMI support is enabled in the kernel, there is no simple way to
> > detect if a DMI table is table or not. Note that the variable
> > 'dmi_available' is not exported and so cannot be used by kernel modules.
>
> We could fix that, or provide an accessor function? Or only warn if
> we're on an ACPI system (which we can check from a module). This really
> does feel like something we should be warning about on systems that are
> supposed to have DMI information available as standard.

I had the same feeling when I took a look at the patch, but later
changed mind, since the error will pop up also if a system has an
unmatured BIOS with some bogus vendor DMI string, too. That is, users
of such a machine gets always an error message although this isn't any
serious problem unless you need a dedicated UCM profile (which can't
be used on such a system in anyway).

So, I agree that exporting dmi_avilable could improve the situation a
bit, but the error level needs still reconsideration.


Takashi

\
 
 \ /
  Last update: 2021-03-02 20:57    [W:0.048 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site