Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 2 Mar 2021 17:05:00 +0100 | Subject | Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading |
| |
On Tue, Mar 2, 2021 at 4:58 AM DENG Qingfang <dqfext@gmail.com> wrote: > On Mon, Mar 1, 2021 at 9:48 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > With my minor changes: > > Tested-by: Linus Walleij <linus.walleij@linaro.org> > > How about using a mutex lock in port_bridge_{join,leave} ? > In my opinion all functions that access multiple registers should be > synchronized.
That's one way, in some cases the framework (DSA) serialize the accesses so I don't know if that already happens on a higher level? Since it is accessed over a slow bus we should go for mutex in that case indeed.
Yours, Linus Walleij
| |