lkml.org 
[lkml]   [2021]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v1 2/2] mmc: cavium: Remove redundant if-statement checkup
    From
    Date
    On Fri, 2021-03-19 at 15:09 +0100, Ulf Hansson wrote:
    > On Fri, 19 Mar 2021 at 13:14, Bean Huo <huobean@gmail.com> wrote:
    >
    > > From: Bean Huo <beanhuo@micron.com>
    > > Currently, we have two ways to issue multiple-block read/write the
    > > command to the eMMC. One is by normal IO request path fs->block-
    > > >mmc.
    > > Another one is that we can issue multiple-block read/write through
    > > MMC ioctl interface. For the first path, mrq->stop, and mrq->stop-
    > > >opcode
    > > will be initialized in mmc_blk_data_prep(). However, for the second
    > > IO
    > > path, mrq->stop is not initialized since it is a pre-defined
    > > multiple
    > > blocks read/write.
    >
    >
    > As a matter of fact this way is also supported for the regular block
    >
    > I/O path. To make the mmc block driver to use it, mmc host drivers
    >
    > need to announce that it's supported by setting MMC_CAP_CMD23.
    >
    >
    >
    > It looks like that is what your patch should be targeted towards, can
    >
    > you have a look at this instead?
    >
    >

    Hi Ulf,
    Thanks for your comments. I will look at that as your suggestion.
    The patch [1/2] is accepted, so I will just update this patch to
    the next version.

    Kind regards,
    Bean

    >
    > Kind regards
    >
    > Uffe

    \
     
     \ /
      Last update: 2021-03-19 16:44    [W:3.031 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site