Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 19 Mar 2021 12:04:08 +0200 | Subject | Re: [PATCH v3 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero |
| |
On Fri, Mar 19, 2021 at 9:53 AM Hawa, Hanna <hhhawa@amazon.com> wrote: > On 3/18/2021 2:15 PM, Andy Shevchenko wrote: > > On Wed, Mar 17, 2021 at 11:42 PM Hanna Hawa<hhhawa@amazon.com> wrote: > >> An SError was detected when trying to print the supported pins in a > > What is SError? Yes, I have read a discussion, but here is the hint: > > if a person sees this as a first text due to, for example, bisecting > > an issue, what she/he can get from this cryptic name? > > What you suggest? > s/An SError/A kernel-panic/?
Not below, but something which makes clear what SError is.
Like "A System Error (SError, followed by kernel panic) ..."
> Or remove the sentence and keep the below: > " > This change fixes the pcs_pin_dbg_show() in pinctrl-single driver when > bits_per_mux is not zero. In addition move offset calculation and pin > offset in register to common function. > "
-- With Best Regards, Andy Shevchenko
| |