Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v4 4/9] kentry: Simplify the common syscall API | Date | Fri, 19 Mar 2021 19:07:20 +0100 |
| |
On Wed, Mar 17 2021 at 11:12, Andy Lutomirski wrote: > @@ -119,31 +119,12 @@ static inline __must_check int arch_syscall_enter_tracehook(struct pt_regs *regs > void enter_from_user_mode(struct pt_regs *regs); > > /** > + * kentry_syscall_begin - Prepare to invoke a syscall handler > * @regs: Pointer to currents pt_regs > * @syscall: The syscall number > * > * Invoked from architecture specific syscall entry code with interrupts > - * enabled after invoking syscall_enter_from_user_mode_prepare() and extra > - * architecture specific work. > + * enabled after kentry_enter_from_usermode or a similar function.
Please write functions with () at the end. Also what the heck means 'similar function' here? I really spent quite some time to document this stuff and it wants to stay that way.
> * > + * Called with IRQs on. Returns with IRQs still on.
interrupts enabled please. This is technical documentation and not twatter.
> +void kentry_syscall_end(struct pt_regs *regs);
Thanks,
tglx
| |