Messages in this thread | | | Subject | Re: [PATCH 1/3] gcov: combine common code | From | Peter Oberparleiter <> | Date | Fri, 19 Mar 2021 18:25:22 +0100 |
| |
On 15.03.2021 23:54, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > There's a lot of duplicated code between gcc and clang > implementations, move it over to fs.c to simplify the > code, there's no reason to believe that for small data > like this one would not just implement the simple > convert_to_gcda() function. > > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
I successfully tested this patch set using GCC on s390, but had some problems using Clang with gcov-kernel (which seem unrelated to this patch set - still to be investigated).
The removal of duplicated code definitively makes sense and this approach looks like it will help make the build-time test I have in mind for gcov-kernel easier to implement.
As such, for all 3 patches (not sure if it makes a difference seeing that this has already landed in linux-next):
Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Regards, Peter
-- Peter Oberparleiter Linux on Z Development - IBM Germany
| |