lkml.org 
[lkml]   [2021]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 03/19] media: i2c: max9286: Cache channel amplitude
    Date
    Cache the current channel amplitude in a driver variable
    to skip updating it if the newly requested value is the same
    as the currently configured one.

    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
    ---
    drivers/media/i2c/max9286.c | 13 ++++++++++---
    1 file changed, 10 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
    index 82ec05e96cb7..ed1cdefe7c30 100644
    --- a/drivers/media/i2c/max9286.c
    +++ b/drivers/media/i2c/max9286.c
    @@ -165,6 +165,7 @@ struct max9286_priv {

    /* The initial reverse control channel amplitude. */
    u32 init_rev_chan_mv;
    + u32 rev_chan_mv;

    struct v4l2_ctrl_handler ctrls;
    struct v4l2_ctrl *pixelrate;
    @@ -341,8 +342,15 @@ static void max9286_configure_i2c(struct max9286_priv *priv, bool localack)
    static void max9286_reverse_channel_setup(struct max9286_priv *priv,
    unsigned int chan_amplitude)
    {
    + u8 chan_config;
    +
    + if (priv->rev_chan_mv == chan_amplitude)
    + return;
    +
    + priv->rev_chan_mv = chan_amplitude;
    +
    /* Reverse channel transmission time: default to 1. */
    - u8 chan_config = MAX9286_REV_TRF(1);
    + chan_config = MAX9286_REV_TRF(1);

    /*
    * Reverse channel setup.
    @@ -564,8 +572,7 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
    * - Disable auto-ack as communication on the control channel are now
    * stable.
    */
    - if (priv->init_rev_chan_mv < 170)
    - max9286_reverse_channel_setup(priv, 170);
    + max9286_reverse_channel_setup(priv, 170);
    max9286_check_config_link(priv, priv->source_mask);

    /*
    --
    2.30.0
    \
     
     \ /
      Last update: 2021-03-19 17:42    [W:3.196 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site