lkml.org 
[lkml]   [2021]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit
On Thu, Mar 18, 2021 at 4:00 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thu, Mar 18, 2021 at 02:43:18PM +0100, Arnd Bergmann wrote:
>
> v4l2_event vs. v4l2_event32 vs. v4l2_event_time32 vs.
> v4l2_event32_time32 is a bit confusing. Do I understand correctly that
> the code below runs for the non-compat path, thus native userspace
> (32-bit on 32-bit machines, 64-bit on 64-bit machines), and handles the
> case of a native userspace using a 32-bit time ? If so it indeed doesn't
> make sense for 64-bit machines.

Yes, that's correct. The way the structures are defined, we have
all four combinations of native/compat pointer and time64/time32
timestamps, but the combination of native pointer with time32
stamps only makes sense for 32-bit users.

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks,

Arnd

\
 
 \ /
  Last update: 2021-03-18 16:27    [W:0.080 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site