Messages in this thread | | | Subject | Re: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support | From | Pierre-Louis Bossart <> | Date | Thu, 18 Mar 2021 05:57:15 -0500 |
| |
On 3/17/21 8:21 PM, Jack Yu wrote: >>> This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset >>> codec and ALC1015Q-VB speaker amplifier combination on JasperLake >>> platform. >>> >>> This driver also supports ALC1015Q-CG if running in auto-mode. >>> Following table shows the audio interface support of the two >>> amplifiers. >>> >>> | ALC1015Q-CG | ALC1015Q-VB >>> ===================================== >>> I2C | Yes | No >>> Auto-mode | 48K, 64fs | 16k, 32fs >>> | 48k, 32fs >>> | 48k, 64fs >>> >>> Signed-off-by: Brent Lu <brent.lu@intel.com> >> >> The code is looks fine, but Jack Yu added a separate patch that makes >> RTL1019 equivalent to RTL1015, so should this patch also handle the >> RTL1019 case? >> > For rt1019 non-i2c mode (auto mode), it uses the sdb pin to enable amp, the same as rt1015 non-i2c mode, > therefore we propose rt1019(auto mode) to use rt1015p instead of adding a new driver for it.
ok, that's fine.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
| |