lkml.org 
[lkml]   [2021]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/10] of: dynamic: Fix incorrect parameter name and provide missing descriptions
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/of/dynamic.c:234: warning: Function parameter or member 'np' not described in 'of_attach_node'
    drivers/of/dynamic.c:286: warning: Function parameter or member 'np' not described in 'of_detach_node'
    drivers/of/dynamic.c:326: warning: Function parameter or member 'kobj' not described in 'of_node_release'
    drivers/of/dynamic.c:326: warning: Excess function parameter 'kref' description in 'of_node_release'

    Cc: Rob Herring <robh+dt@kernel.org>
    Cc: Frank Rowand <frowand.list@gmail.com>
    Cc: devicetree@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/of/dynamic.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
    index 9a824decf61f1..1d7a22e44d787 100644
    --- a/drivers/of/dynamic.c
    +++ b/drivers/of/dynamic.c
    @@ -229,6 +229,7 @@ static void __of_attach_node(struct device_node *np)

    /**
    * of_attach_node() - Plug a device node into the tree and global list.
    + * @np: Pointer to the caller's Device Node
    */
    int of_attach_node(struct device_node *np)
    {
    @@ -281,6 +282,7 @@ void __of_detach_node(struct device_node *np)

    /**
    * of_detach_node() - "Unplug" a node from the device tree.
    + * @np: Pointer to the caller's Device Node
    */
    int of_detach_node(struct device_node *np)
    {
    @@ -318,7 +320,7 @@ static void property_list_free(struct property *prop_list)

    /**
    * of_node_release() - release a dynamically allocated node
    - * @kref: kref element of the node to be released
    + * @kobj: kernel object of the node to be released
    *
    * In of_node_put() this function is passed to kref_put() as the destructor.
    */
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-03-18 11:43    [W:8.782 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site