lkml.org 
[lkml]   [2021]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: A potential data race in drivers/iio/adc/berlin2-adc.ko
From
Date
On 3/18/21 9:07 AM, Pavel Andrianov wrote:
> Hi,
>
> berlin2_adc_probe [1] registers two interrupt handlers:
> berlin2_adc_irq [2]
> and berlin2_adc_tsen_irq [3]. The interrupt handlers operate with the
> same data, for example, modify
> priv->data with different masks:
>
> priv->data &= BERLIN2_SM_ADC_MASK;
> and
> priv->data &= BERLIN2_SM_TSEN_MASK;
>
> If the two interrupt handlers are executed simultaneously, a potential
> data race takes place. So, the question is if the situation is
> possible. For example, in the case of the handlers are executed on
> different CPU cores.
>
> Best regards,
> Pavel
>
> [1]
> https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/berlin2-adc.c#L283
>
> [2]
> https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/berlin2-adc.c#L239
>
> [3]
> https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/berlin2-adc.c#L259
>
Looking at the code there are two functions. berlin2_adc_tsen_read() and
berlin2_adc_read(). These two function are take the same mutex and can
not run concurrently. At the beginning of the protected section the
corresponding interrupt for that function is enabled and at the end
disabled. So at least if the hardware works correctly those two
interrupts will never fire at the same time.

Now, if the hardware misbehaves the two interrupts could still fire at
the same time.

- Lars

\
 
 \ /
  Last update: 2021-03-18 09:29    [W:0.336 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site